Implement proper static completion generation for NuShell #52343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
@jlcrochet This is awesome, THANK YOU for taking the time to do this. Would it be possible to get something like an asciinema recording/gif of the completions working and what the experience looks like for those of us without nushell? |
Author
|
I edited a link to the asciinema in the original comment. |
It seems that descriptions for argument and option values don't display if the completion list is inlined, so we have to generate completion commands for these.
In the case where we use sentences for descriptions, strip the period off the end for consistency. In the case where we use the first line of a description, we should *not* use it if it ends with a punctuation character indicating the beginning of an overly complex description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new static completions provider makes use of NuShell's
externto define completions fordotnetcommands. Similarly to the other shell providers it falls back todotnet completein cases where dynamic completion of option values is needed.asciinema example usage: https://asciinema.org/a/wFSDtsB2eui8JsUe
Attached is what the output of
dotnet completions script nushelllooks like.dotnet-completions.txt