Improve the build-perf-diag scenario test - #404
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dotnet-msbuild/build-perf-diagnostics evaluation scenario to better reflect a realistic “small project, slow build” investigation so it’s less solvable via generic advice without using the skill’s diagnostic workflow.
Changes:
- Reworked the scenario prompt/rubric and loosened the output assertion; increased timeout.
- Adjusted
Directory.Build.propsto add more build-time/quality-enforcement settings. - Updated the sample project code/namespace and added logging abstractions dependency.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/dotnet-msbuild/build-perf-diagnostics/eval.yaml | Rewords scenario + updates rubric/assertions and extends timeout. |
| tests/dotnet-msbuild/build-perf-diagnostics/Directory.Build.props | Adds additional build properties affecting performance/quality enforcement. |
| tests/dotnet-msbuild/build-perf-diagnostics/DataService.cs | Replaces prior “heavy” class with a more realistic service and adds logging. |
| tests/dotnet-msbuild/build-perf-diagnostics/Contoso.WebApi.csproj | Sets root namespace and adds logging abstractions package reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ViktorHofer
approved these changes
Mar 19, 2026
Member
Author
|
/evaluate |
Contributor
Skill Validation Results
[1] (Plugin) Quality unchanged but weighted score is -31.0% due to: judgment, quality, tokens (115361 → 502605), tool calls (11 → 24), time (103.7s → 166.6s) Model: claude-opus-4.6 | Judge: claude-opus-4.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
build-perf-diag consistently scoring low with skill.
The health analyzer analyzsis: #288 (comment)
tl;dr; The test was too obvious to be solvable without skill