-
Notifications
You must be signed in to change notification settings - Fork 394
[release/10.0.1xx] Source code updates from dotnet/dotnet #9599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0.1xx
Are you sure you want to change the base?
[release/10.0.1xx] Source code updates from dotnet/dotnet #9599
Conversation
[[ commit created by automation ]]
…b69d-ae537f9ee877
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk (Version 10.0.0-beta.25568.102 -> 10.0.0-beta.25604.105) System.CommandLine (Version 2.0.1 -> 2.0.2)
|
Important The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes. Please continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
…49d-4ea6-b69d-ae537f9ee877
|
For some reason, many tests are trying to resolve a 9.0 runtime on osx/linux. I wonder if its because 10 is not available. |
…49d-4ea6-b69d-ae537f9ee877
|
At first, I thought mariner-2 maybe dropped .net 9 support and we switched to new image runners. Then I tried to set NetMinimum in directory.build.props to .NET 10. But I didn't see that property propagate, and some of TE still builds on .NET 8. I don't have the context as to why. FYI @dotnet/templating-engine-maintainers Instead, I've tried to make it so .NET 9 is installed via the pipeline to see if this makes it so it can find the .NET 9 runtime. |
…877' of https://github.com/dotnet/templating into darc-release/10.0.1xx-6b5cb72a-a49d-4ea6-b69d-ae537f9ee877
|
It's still failing to load .NET 9. It's also got an authoring issue: |
|
Surprisingly, the tests work on my linux machine without .net 9.0. I haven't been able to reproduce this yet. |
|
The issue is in |
|
I'm going to try to refresh or stop this cache in the CI machine so we can evaluate my hypothesis. If my hypothesis is true, I think we should consider filing this as a potential code issue. |
|
I have higher confidence because this has happened before https://github.com/dotnet/templating/pull/8952/files and #9052 Now, what I don't yet know is how NetCurrent is set. |
|
Some dark magic sets it to 10.0. Net Previous is 9 while minimum is 8. I think we should consider this. |
|
TargetFrameworkDefaults from arcade.sdk sets all of these values. I'm wondering if this is a break from arcade. |
|
Prior to codeflow: current: 10 It's the same :/ So, I imagine this is an issue with the cache not working due to a rollout of .NET. |
|
Ugh, nvm. |
This reverts commit ada559b.
|
@dotnet/templating-engine-maintainers It seems like the template cache is broken. It's trying to rely on .NET 9. I'm thinking it's got some cached values and now it's trying to load something it shouldn't. #9052 seemed to track this in the past. I don't know if you want to disable the cache in the tests only, disable it in code because it's got a bug, or try to fix the bug for .NET 10. Either way, hopefully this research and context I did helps. |
|
TemplateSearch package is built against .net 8 from what I can tell, at least based on what I downloaded from the pipeline |
|
Based on what I'm seeing, the deps.json shows that it target 8.0, but has a dependency on logging abstractions from 9.0.3, this might be the cause of the problem. |
|
@nagilson I'm testing out a fix in another branch |
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos