-
-
Notifications
You must be signed in to change notification settings - Fork 356
doc(EditorForm): add IsDisplay parameter documentation #6679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enhances the EditorForms sample by adding a dedicated demo for the new IsDisplay parameter (including model initialization) and updates localization entries for both English and Chinese Class diagram for updated EditorForms model initializationclassDiagram
class EditorForms {
+Model: Foo
+OnInitialized()
}
class Foo {
+Hobby: IEnumerable<string>
+GenerateHobbies(localizer): IEnumerable<Hobby>
}
EditorForms --> Foo
EditorForms : OnInitialized() sets Model.Hobby using Foo.GenerateHobbies()
Foo : Hobby property initialized with first 3 hobby texts
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for the IsDisplay
parameter in the EditorForm component by creating a new demo section that demonstrates readonly form functionality.
- Adds localized text entries for the new readonly form demonstration
- Creates a new demo block showing how to make forms non-editable using
IsDisplay="true"
- Initializes model hobby data to support the demonstration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/BootstrapBlazor.Server/Locales/zh-CN.json | Adds Chinese localization strings for readonly form demo |
src/BootstrapBlazor.Server/Locales/en-US.json | Adds English localization strings for readonly form demo |
src/BootstrapBlazor.Server/Components/Samples/EditorForms.razor.cs | Initializes model hobby data for demonstration |
src/BootstrapBlazor.Server/Components/Samples/EditorForms.razor | Adds new demo block showcasing IsDisplay parameter |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6679 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31698 31698
Branches 4462 4462
=========================================
Hits 31698 31698
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6678
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Document the IsDisplay parameter in EditorForm by adding a demo block showcasing its usage, initializing the sample model accordingly, and adding corresponding localization entries
Enhancements: