Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Sep 13, 2025

Link issues

fixes #6740

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add warnings to the Modbus and Socket factory sample components indicating that they require Socket support and are not supported in WASM mode.

Documentation:

  • Insert tips in ModbusFactories.razor to note that the service needs Socket support and isn’t available in WASM mode
  • Insert tips in SocketFactories.razor to note that the service needs Socket support and isn’t available in WASM mode

@Copilot Copilot AI review requested due to automatic review settings September 13, 2025 15:35
@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Sep 13, 2025
@bb-auto bb-auto bot added this to the 9.10.0 milestone Sep 13, 2025
Copy link
Contributor

sourcery-ai bot commented Sep 13, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the sample documentation to clearly indicate that the Longbow.Modbus and Longbow.TcpSocket services require full Socket support and are not compatible with WASM mode.

File-Level Changes

Change Details Files
Add warning tip about WASM incompatibility in Modbus sample
  • Inserted a block with a message that Socket support is required and WASM mode is not supported
src/BootstrapBlazor.Server/Components/Samples/Modbus/ModbusFactories.razor
Add warning tip about WASM incompatibility in Socket sample
  • Inserted a block with a message that Socket support is required and WASM mode is not supported
src/BootstrapBlazor.Server/Components/Samples/Sockets/SocketFactories.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6740 Add documentation indicating that Modbus does not support wasm.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation to inform users that Modbus and Socket services do not support WebAssembly (WASM) mode, addressing issue #6740. It also updates package references to newer versions.

  • Adds warning documentation about WASM incompatibility for Modbus and Socket factories
  • Updates package versions for Longbow.Modbus, Longbow.Sockets, and Longbow.TcpSocket

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
ModbusFactories.razor Adds WASM incompatibility warning for Modbus services
SocketFactories.razor Adds WASM incompatibility warning for Socket services
BootstrapBlazor.Server.csproj Updates package references to newer versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArgoZhang ArgoZhang enabled auto-merge (squash) September 13, 2025 15:35
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (02b014c) to head (c78f6b6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6741   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31713     31713           
  Branches      4462      4462           
=========================================
  Hits         31713     31713           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit faec42f into main Sep 13, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the doc-bus branch September 13, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(Modbus): add not support wasm documentation
1 participant