-
-
Notifications
You must be signed in to change notification settings - Fork 356
doc(Modbus): add not support wasm documentation #6741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the sample documentation to clearly indicate that the Longbow.Modbus and Longbow.TcpSocket services require full Socket support and are not compatible with WASM mode. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation to inform users that Modbus and Socket services do not support WebAssembly (WASM) mode, addressing issue #6740. It also updates package references to newer versions.
- Adds warning documentation about WASM incompatibility for Modbus and Socket factories
- Updates package versions for Longbow.Modbus, Longbow.Sockets, and Longbow.TcpSocket
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
ModbusFactories.razor | Adds WASM incompatibility warning for Modbus services |
SocketFactories.razor | Adds WASM incompatibility warning for Socket services |
BootstrapBlazor.Server.csproj | Updates package references to newer versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6741 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31713 31713
Branches 4462 4462
=========================================
Hits 31713 31713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6740
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add warnings to the Modbus and Socket factory sample components indicating that they require Socket support and are not supported in WASM mode.
Documentation: