-
-
Notifications
You must be signed in to change notification settings - Fork 357
doc(Socket): remove DataTypeConverter attribute #6745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideClean up the SocketFactories sample by removing the obsolete DataTypeConverter attribute from the MockEntity class declaration to align documentation with the current attribute usage. Class diagram for MockEntity after removing DataTypeConverter attributeclassDiagram
class MockEntity {
+byte[] Header
}
MockEntity : [DataPropertyConverter(Type = typeof(byte[]), Offset = 0, Length = 5)] Header
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the DataTypeConverter
attribute from the Socket documentation example code. The change simplifies the data adapter design documentation by removing the class-level converter attribute while keeping the property-level converter attributes intact.
Comments suppressed due to low confidence (1)
src/BootstrapBlazor.Server/Components/Samples/Sockets/SocketFactories.razor:119
- The
<code></code>
tags are empty and contain no content. This appears to be incomplete documentation that should either be removed or properly filled in.
<p>使用 <code></code></p>
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link issues
fixes #6744
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the obsolete DataTypeConverter attribute annotation from the MockEntity class in the SocketFactories sample to fix issue #6744.
Bug Fixes:
Documentation: