-
-
Notifications
You must be signed in to change notification settings - Fork 356
doc(TcpSocket): use extension method ReceiveAsync #6750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR resolves issue #6749 by standardizing the data adapter callback property in the TcpSocket sample to align with the ReceiveAsync extension method, and updates the project file to include the necessary extension method support. Sequence diagram for ReceiveAsync callback flow in TcpSocket samplesequenceDiagram
participant Client as TcpSocketClient
participant Adapter as DataAdapter
participant "UpdateReceiveLog()" as UpdateReceiveLog
Client->>Adapter: Set ReceivedCallback
Adapter->>"UpdateReceiveLog()": Invoke callback on data received
Class diagram for updated DataAdapter callback propertyclassDiagram
class DataAdapter {
+ReceivedCallback : Action
}
class TcpSocketClient {
+ReceivedCallback : Func<Task>
}
DataAdapter <.. TcpSocketClient : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes spelling inconsistencies and updates package references related to TcpSocket functionality. The changes correct a property name typo and update namespace references to align with updated package versions.
- Fixed spelling inconsistency in property name from
ReceivedCallBack
toReceivedCallback
- Updated package versions for Longbow.Modbus, Longbow.Sockets, and Longbow.TcpSocket
- Corrected namespace references from
Longbow.Socket.*
toLongbow.Sockets.*
to match updated packages
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
Adapters.razor.cs | Fixed property name spelling from ReceivedCallBack to ReceivedCallback |
BootstrapBlazor.Server.csproj | Updated package versions and corrected namespace references for socket-related packages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6750 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31713 31713
Branches 4462 4462
=========================================
Hits 31713 31713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6749
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: