Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Sep 17, 2025

Link issues

fixes #6749

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Correct the data adapter callback property name from ReceivedCallBack to ReceivedCallback in the TcpSocket sample

@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 08:00
@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Sep 17, 2025
@bb-auto bb-auto bot added this to the 9.10.0 milestone Sep 17, 2025
Copy link
Contributor

sourcery-ai bot commented Sep 17, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR resolves issue #6749 by standardizing the data adapter callback property in the TcpSocket sample to align with the ReceiveAsync extension method, and updates the project file to include the necessary extension method support.

Sequence diagram for ReceiveAsync callback flow in TcpSocket sample

sequenceDiagram
participant Client as TcpSocketClient
participant Adapter as DataAdapter
participant "UpdateReceiveLog()" as UpdateReceiveLog

Client->>Adapter: Set ReceivedCallback
Adapter->>"UpdateReceiveLog()": Invoke callback on data received
Loading

Class diagram for updated DataAdapter callback property

classDiagram
class DataAdapter {
  +ReceivedCallback : Action
}

class TcpSocketClient {
  +ReceivedCallback : Func<Task>
}

DataAdapter <.. TcpSocketClient : uses
Loading

File-Level Changes

Change Details Files
Fixed the data adapter callback assignment typo and aligned it with the ReceiveAsync extension method
  • Replaced _dataAdapter.ReceivedCallBack with _dataAdapter.ReceivedCallback
  • Ensured the sample uses the new extension method for receiving data asynchronously
Adapters.razor.cs
Updated project file to support the ReceiveAsync extension
  • Added or updated package reference for the extension method support in the server project
  • Bumped package version to include the latest TcpSocket extension
BootstrapBlazor.Server.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#6749 Add sample code for TcpSocket using the extension method ReceiveAsync. The diff only corrects a property name from 'ReceivedCallBack' to 'ReceivedCallback' in Adapters.razor.cs and does not add any sample code demonstrating the use of the ReceiveAsync extension method for TcpSocket.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes spelling inconsistencies and updates package references related to TcpSocket functionality. The changes correct a property name typo and update namespace references to align with updated package versions.

  • Fixed spelling inconsistency in property name from ReceivedCallBack to ReceivedCallback
  • Updated package versions for Longbow.Modbus, Longbow.Sockets, and Longbow.TcpSocket
  • Corrected namespace references from Longbow.Socket.* to Longbow.Sockets.* to match updated packages

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Adapters.razor.cs Fixed property name spelling from ReceivedCallBack to ReceivedCallback
BootstrapBlazor.Server.csproj Updated package versions and corrected namespace references for socket-related packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit c198c04 into main Sep 17, 2025
5 of 6 checks passed
@ArgoZhang ArgoZhang deleted the refactor-doc branch September 17, 2025 08:02
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d00d387) to head (a4f6835).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6750   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31713     31713           
  Branches      4462      4462           
=========================================
  Hits         31713     31713           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(TcpSocket): use extension method ReceiveAsync
1 participant