Skip to content

Commit

Permalink
Drop using owner score as fallback over type score
Browse files Browse the repository at this point in the history
since it was under the case matching ownerScore to 0
  • Loading branch information
EugeneFlesselle committed Jul 28, 2024
1 parent 36a74b0 commit e1cc065
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions compiler/src/dotty/tools/dotc/typer/Applications.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1981,12 +1981,6 @@ trait Applications extends Compatibility {
case 0 =>
if winsType1 != winsType2 then if winsType1 then 1 else -1
else if alt1.symbol == alt2.symbol then comparePrefixes
else if preferGeneral then
// For implicit resolution, take ownerscore as more significat than type resoltion
// Reason: People use owner hierarchies to explicitly prioritize, we should not
// break that by changing implicit priority of types. On the other hand we do want
// to comparePrefixes if there is a draw; StringFormaterTest breaks if we don't do that.
ownerScore
else 0
end compareWithTypes

Expand Down

0 comments on commit e1cc065

Please sign in to comment.