Use http datasource for local urls#101
Merged
dcvz merged 3 commits intodoublesymmetry:mainfrom Mar 5, 2024
Merged
Conversation
Contributor
Author
|
@dcvz Would it be possible to take a look at this PR? Thanks a lot! |
dcvz
approved these changes
Feb 6, 2024
Contributor
dcvz
left a comment
dcvz
left a comment
There was a problem hiding this comment.
Looks good! Left one small comment -- overall I think there should be no big impact in using DefaultHttpDataSource for these, so let's go ahead
…s/Utils.kt Co-authored-by: David Chavez <david@dcvz.io>
dcvz
approved these changes
Mar 5, 2024
Contributor
|
@janwiebe-jump I'm ready to merge this but the sample is failing to build. Looks like there's a syntax error in
|
Contributor
Author
|
@dcvz Sorry for that typo. Pushed the fix. |
Contributor
|
Merged! Thanks for the contribution @janwiebe-jump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all local urls are retrieved by the
DefaultDataSourceFactory. However, in my case I want to use localhost urls that return a redirect (302) to the actual mp3.Therefore, since they are http/https urls, they should be handled by
DefaultHttpDataSourceso the redirect is followed.This PR fixes the check
isLocalUrito match local file uris only.I have tested this with React Native Track Player.