Skip to content

Commit

Permalink
Remove unnecessary buffer settings from tests. (#26)
Browse files Browse the repository at this point in the history 
As expected, the tests run successfully without these set too. See doublesymmetry/react-native-track-player#1695
  • Loading branch information
@puckey
puckey authored Sep 6, 2022
1 parent 38429c6 commit 24c19aa
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 57 deletions.
60 changes: 29 additions & 31 deletions Example/Tests/AudioPlayerTests.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,34 +6,32 @@ import XCTest
@testable import SwiftAudioEx

class AudioPlayerTests: XCTestCase {

var audioPlayer: AudioPlayer!
var listener: AudioPlayerEventListener!

override func setUp() {
super.setUp()
audioPlayer = AudioPlayer()
audioPlayer.volume = 0.0
audioPlayer.bufferDuration = 0.001
audioPlayer.automaticallyWaitsToMinimizeStalling = false
listener = AudioPlayerEventListener(audioPlayer: audioPlayer)
}

override func tearDown() {
audioPlayer = nil
listener = nil
super.tearDown()
}

func test_AudioPlayer__state__should_be_idle() {
XCTAssert(audioPlayer.playerState == AudioPlayerState.idle)
}

func test_AudioPlayer__state__load_source__should_be_loading() {
try? audioPlayer.load(item: Source.getAudioItem(), playWhenReady: false)
XCTAssertEqual(audioPlayer.playerState, AudioPlayerState.loading)
}

func test_AudioPlayer__state__load_source__should_be_ready() {
let expectation = XCTestExpectation()
listener.stateUpdate = { state in
Expand All @@ -45,7 +43,7 @@ class AudioPlayerTests: XCTestCase {
try? audioPlayer.load(item: Source.getAudioItem(), playWhenReady: false)
wait(for: [expectation], timeout: 20.0)
}

func test_AudioPlayer__state__load_source_playWhenReady__should_be_playing() {
let expectation = XCTestExpectation()
listener.stateUpdate = { state in
Expand All @@ -57,7 +55,7 @@ class AudioPlayerTests: XCTestCase {
try? audioPlayer.load(item: Source.getAudioItem(), playWhenReady: true)
wait(for: [expectation], timeout: 20.0)
}

func test_AudioPlayer__state__play_source__should_be_playing() {
let expectation = XCTestExpectation()
listener.stateUpdate = { state in
Expand All @@ -70,7 +68,7 @@ class AudioPlayerTests: XCTestCase {
try? audioPlayer.load(item: Source.getAudioItem(), playWhenReady: false)
wait(for: [expectation], timeout: 20.0)
}

func test_AudioPlayer__state__pausing_source__should_be_paused() {
let expectation = XCTestExpectation()
listener.stateUpdate = { [weak audioPlayer] state in
Expand All @@ -83,7 +81,7 @@ class AudioPlayerTests: XCTestCase {
try? audioPlayer.load(item: Source.getAudioItem(), playWhenReady: true)
wait(for: [expectation], timeout: 20.0)
}

func test_AudioPlayer__state__stopping_source__should_be_idle() {
let expectation = XCTestExpectation()
var hasBeenPlaying: Bool = false
Expand All @@ -102,13 +100,13 @@ class AudioPlayerTests: XCTestCase {
try? audioPlayer.load(item: Source.getAudioItem(), playWhenReady: true)
wait(for: [expectation], timeout: 20.0)
}

// MARK: - Current time

func test_AudioPlayer__currentTime__should_be_0() {
XCTAssert(audioPlayer.currentTime == 0.0)
}

// Commented out -- Keeps failing in CI at Bitrise, but succeeds locally, even with Bitrise CLI.
// func test_AudioPlayer__currentTime__playing_source__shold_be_greater_than_0() {
// let expectation = XCTestExpectation()
Expand All @@ -121,13 +119,13 @@ class AudioPlayerTests: XCTestCase {
// try? audioPlayer.load(item: LongSource.getAudioItem(), playWhenReady: true)
// wait(for: [expectation], timeout: 20.0)
// }

// MARK: - Rate

func test_AudioPlayer__rate__should_be_1() {
XCTAssert(audioPlayer.rate == 1.0)
}

func test_AudioPlayer__rate__playing_source__should_be_1() {
let expectation = XCTestExpectation()
listener.stateUpdate = { [weak audioPlayer] state in
Expand All @@ -143,13 +141,13 @@ class AudioPlayerTests: XCTestCase {
try? audioPlayer.load(item: Source.getAudioItem(), playWhenReady: true)
wait(for: [expectation], timeout: 20.0)
}

// MARK: - Current item

func test_AudioPlayer__currentItem__should_be_nil() {
XCTAssertNil(audioPlayer.currentItem)
}

func test_AudioPlayer__currentItem__loading_source__should_not_be_nil() {
let expectation = XCTestExpectation()
listener.stateUpdate = { [weak audioPlayer] state in
Expand All @@ -165,47 +163,47 @@ class AudioPlayerTests: XCTestCase {
try? audioPlayer.load(item: Source.getAudioItem(), playWhenReady: false)
wait(for: [expectation], timeout: 20.0)
}

}

class AudioPlayerEventListener {

var state: AudioPlayerState? {
didSet {
if let state = state {
stateUpdate?(state)
}
}
}

var stateUpdate: ((_ state: AudioPlayerState) -> Void)?
var secondsElapse: ((_ seconds: TimeInterval) -> Void)?
var seekCompletion: (() -> Void)?

weak var audioPlayer: AudioPlayer?

init(audioPlayer: AudioPlayer) {
audioPlayer.event.stateChange.addListener(self, handleDidUpdateState)
audioPlayer.event.seek.addListener(self, handleSeek)
audioPlayer.event.secondElapse.addListener(self, handleSecondsElapse)
}

deinit {
audioPlayer?.event.stateChange.removeListener(self)
audioPlayer?.event.seek.removeListener(self)
audioPlayer?.event.secondElapse.removeListener(self)
}

func handleDidUpdateState(state: AudioPlayerState) {
self.state = state
}

func handleSeek(data: AudioPlayer.SeekEventData) {
seekCompletion?()
}

func handleSecondsElapse(data: AudioPlayer.SecondElapseEventData) {
self.secondsElapse?(data)
}

}
50 changes: 24 additions & 26 deletions Example/Tests/QueuedAudioPlayerTests.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,13 @@ class QueuedAudioPlayerTests: QuickSpec {
var audioPlayer: QueuedAudioPlayer!
beforeEach {
audioPlayer = QueuedAudioPlayer()
audioPlayer.bufferDuration = 0.0001
audioPlayer.automaticallyWaitsToMinimizeStalling = false
audioPlayer.volume = 0.0
}
describe("its current item") {
it("should be nil") {
expect(audioPlayer.currentItem).to(beNil())
}

context("when adding one item") {
var item: AudioItem!
beforeEach {
Expand All @@ -42,18 +40,18 @@ class QueuedAudioPlayerTests: QuickSpec {
it("should not be nil") {
expect(audioPlayer.currentItem).toNot(beNil())
}

context("then loading a new item") {
beforeEach {
try? audioPlayer.load(item: Source.getAudioItem(), playWhenReady: false)
}

it("should have replaced the item") {
expect(audioPlayer.currentItem?.getSourceUrl()).toNot(equal(item.getSourceUrl()))
}
}
}

context("when adding multiple items") {
beforeEach {
try? audioPlayer.add(items: [ShortSource.getAudioItem(), ShortSource.getAudioItem()], playWhenReady: false)
Expand All @@ -63,28 +61,28 @@ class QueuedAudioPlayerTests: QuickSpec {
}
}
}

describe("its next items") {
it("should be empty") {
expect(audioPlayer.nextItems.count).to(equal(0))
}

context("when adding 2 items") {
beforeEach {
try? audioPlayer.add(items: [Source.getAudioItem(), Source.getAudioItem()])
}
it("should contain 1 item") {
expect(audioPlayer.nextItems.count).to(equal(1))
}

context("then calling next()") {
beforeEach {
try? audioPlayer.next()
}
it("should contain 0 items") {
expect(audioPlayer.nextItems.count).to(equal(0))
}

context("then calling previous()") {
beforeEach {
try? audioPlayer.previous()
Expand All @@ -94,17 +92,17 @@ class QueuedAudioPlayerTests: QuickSpec {
}
}
}

context("then removing one item") {
beforeEach {
try? audioPlayer.removeItem(at: 1)
}

it("should be empty") {
expect(audioPlayer.nextItems.count).to(equal(0))
}
}

context("then jumping to the last item") {
beforeEach {
try? audioPlayer.jumpToItem(atIndex: 1)
Expand All @@ -113,43 +111,43 @@ class QueuedAudioPlayerTests: QuickSpec {
expect(audioPlayer.nextItems.count).to(equal(0))
}
}

context("then removing upcoming items") {
beforeEach {
audioPlayer.removeUpcomingItems()
}

it("should be empty") {
expect(audioPlayer.nextItems.count).to(equal(0))
}
}

context("then stopping") {
beforeEach {
audioPlayer.stop()
}

it("should be empty") {
expect(audioPlayer.nextItems.count).to(equal(0))
}
}
}
}

describe("its previous items") {
it("should be empty") {
expect(audioPlayer.previousItems.count).to(equal(0))
}

context("when adding 2 items") {
beforeEach {
try? audioPlayer.add(items: [ShortSource.getAudioItem(), ShortSource.getAudioItem()])
}

it("should be empty") {
expect(audioPlayer.previousItems.count).to(equal(0))
}

context("then calling next()") {
beforeEach {
try? audioPlayer.next()
Expand All @@ -158,27 +156,27 @@ class QueuedAudioPlayerTests: QuickSpec {
expect(audioPlayer.previousItems.count).to(equal(1))
}
}

context("then removing all previous items") {
beforeEach {
audioPlayer.removePreviousItems()
}

it("should be empty") {
expect(audioPlayer.previousItems.count).to(equal(0))
}
}

context("then stopping") {
beforeEach {
audioPlayer.stop()
}

it("should be empty") {
expect(audioPlayer.previousItems.count).to(equal(0))
}
}

}
}

Expand Down

0 comments on commit 24c19aa

Please sign in to comment.