Fix Adding tracks before index in queue #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team was using the react-native-track-player and found that when trying to add tracks before an index, the queue would fail. This was particularly true when just adding one single track. Through that, we diagnosed the problem in the single comparison that we noted.
React-Native Function to replicate problem:
Running this code and tracing through the swift code would show you that the items are not being added when beforeTracks has a size of one. It would work fine when handling more than 2 tracks, but failed in this edge case. We solved it with full functionality when made the comparison to 0 instead of 1.
Seems super silly to PR this, but this one bug had me stuck trying to get our queue manager working for 4 hours, and is the biggest pain in the butt.