Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate clearNowPlayingMetadata #1909

Merged

Conversation

puckey
Copy link
Collaborator

@puckey puckey commented Feb 6, 2023

See #1653

* @deprecated Nominated for removal in the next major version. If you object
* to this, please describe your use-case in the following issue:
* https://github.com/doublesymmetry/react-native-track-player/issues/1653
*/
export function clearNowPlayingMetadata(): Promise<void> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next major version will be the current develop I guess let's deprecate for now but we have to make sure to remove it a few RC's down the line.

Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@jspizziri jspizziri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gavrichards pinging you here as I believe you may use these methods.

@gavrichards
Copy link
Contributor

@gavrichards pinging you here as I believe you may use these methods.

Just checked, we don't use this method. Thanks for the ping!

@dcvz dcvz merged commit ddead98 into doublesymmetry:main Feb 6, 2023
shawna-donnelly pushed a commit to heistdotcom/react-native-track-player that referenced this pull request Apr 4, 2023
shawna-donnelly pushed a commit to heistdotcom/react-native-track-player that referenced this pull request Apr 4, 2023
@watadarkstar
Copy link

watadarkstar commented Jun 20, 2023

@puckey We are on version 3.2 and use clearNowPlayingMetadata method to remove the track player from the notifications tray. See here for more context:
#1834 (comment)

Are you sure you want to deprecate this method? If so, how will we clear the track player from the notification tray? Since calling reset does not clear it from the tray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants