-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate clearNowPlayingMetadata #1909
Deprecate clearNowPlayingMetadata #1909
Conversation
* @deprecated Nominated for removal in the next major version. If you object | ||
* to this, please describe your use-case in the following issue: | ||
* https://github.com/doublesymmetry/react-native-track-player/issues/1653 | ||
*/ | ||
export function clearNowPlayingMetadata(): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next major version will be the current develop
I guess let's deprecate for now but we have to make sure to remove it a few RC's down the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@gavrichards pinging you here as I believe you may use these methods.
Just checked, we don't use this method. Thanks for the ping! |
@puckey We are on version 3.2 and use Are you sure you want to deprecate this method? If so, how will we clear the track player from the notification tray? Since calling |
See #1653