Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(metadata): expanded metadata support #2118

Merged
merged 6 commits into from
Sep 19, 2023
Merged

feature(metadata): expanded metadata support #2118

merged 6 commits into from
Sep 19, 2023

Conversation

dcvz
Copy link
Contributor

@dcvz dcvz commented Sep 7, 2023

Revamps metadata support to return all standard metadata received by the players. An abstraction was built around it to allow users to quickly be able to parse out common keys but also be able to handle any other non standard key.

As part of this change the old metadata events should be marked as deprecated.

NOTE: iOS also gains a method for receiving chapter metadata.

NOTE: This returns all data parsed by the players, one important thing to note is that the native players filter out non-spec/standard keys

Introduced events are:

  • Event.MetatadataChapterReceived (iOS only)
  • Event.MetadataTimedReceived
  • Event.MetadataCommonReceived

TODO:

  • iOS & Android Support
  • Update example project
  • Mark old event as deprecated
  • Update documentation

@dcvz dcvz marked this pull request as ready for review September 19, 2023 09:53
@dcvz dcvz requested a review from jspizziri as a code owner September 19, 2023 09:53
@dcvz dcvz merged commit 1333bfb into main Sep 19, 2023
@dcvz dcvz deleted the request/metadata branch September 19, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant