Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs for queue remove #2294

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix docs for queue remove #2294

merged 2 commits into from
Apr 11, 2024

Conversation

xiaoxu193
Copy link
Contributor

.remove() takes number or number[], not track objects:

react-native-track-player/src/trackPlayer.ts

Line 162 in db86df1

export async function remove(indexes: number[]): Promise<void>;

xiaoxu193 added 2 commits April 8, 2024 16:28
@xiaoxu193
Fix queue remove input paremeter descriptions
c91ffed 
TrackPlayer.remove() takes in a number or number[] instead of track / track[] objects
@xiaoxu193
Update queue.md
7f0f435
@xiaoxu193 xiaoxu193 requested a review from jspizziri as a code owner April 8, 2024 23:32
dcvz
dcvz approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @xiaoxu193 !

@dcvz dcvz merged commit 67a338a into doublesymmetry:main Apr 11, 2024
3 of 5 checks passed
@xiaoxu193 xiaoxu193 deleted the patch-2 branch April 21, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcvz dcvz dcvz approved these changes

@jspizziri jspizziri Awaiting requested review from jspizziri jspizziri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoxu193 @dcvz