fix: pass_thru behavior when the proc is spec-ed via a Proc as last a…

…rgument

v2.4.1 broke backward compatibility in the following case:

   with(some, arguments, Proc).pass_thru

In that case, the block would be given as positional argument to the
original method, instead of being passed as a block.

lib/flexmock/expectation.rb

@@ -128,7 +128,7 @@ def return_value(args, block)
 
       if @expected_block
         ret_block.call(*args, &block)
-      elsif block
+      elsif block && @expected_block.nil?
         ret_block.call(*args, block)
       else
         ret_block.call(*args)
@@ -407,14 +407,21 @@ def pass_thru(&block)
       block ||= lambda { |value| value }
       and_return { |*args, &orig_block|
         begin
+          puts "PASS_THRU #{args} #{orig_block}"
+          if @expected_block.nil? && !orig_block
+            if Proc === args.last
+              orig_block = args.last
+              args = args[0..-2]
+            end
+          end
           block.call(@mock.flexmock_invoke_original(@sym, args, orig_block))
         rescue NoMethodError => e
           if e.name == @sym
             raise e, "#{e.message} while performing #pass_thru in expectation object #{self}"
           else
             raise
           end
-        end 
+        end
       }
     end
 

test/partial_mock_test.rb

@@ -651,6 +651,20 @@ def mocked_method(&block)
     assert_equal block, obj.block
   end
 
+  def test_pass_thru_forwards_a_block_if_there_is_no_explicit_absence
+    obj = Class.new do
+      attr_reader :block
+      def mocked_method(&block)
+        @block = block
+      end
+    end.new
+    flexmock(obj).should_receive(:mocked_method).pass_thru
+
+    block = obj.mocked_method { 42 }
+    assert_kind_of Proc, block
+    assert_equal block, obj.block
+  end
+
   def test_it_checks_whether_mocks_are_forbidden_before_forwarding_the_call
       obj = Class.new
       flexmock(obj).should_receive(:mocked).never