Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow spaces in custom env settings #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

5andr0
Copy link

@5andr0 5andr0 commented May 14, 2022

This patch will allow multiple arguments and spaces for custom settings.

some examples of settings requiring multiple arguments:

ClientTransportPlugin obfs4 exec /usr/bin/obfs4proxy managed
bridge obfs4 141.201.27.48:420 gibberish cert=more-gibberish iat-mode=0
ReachableAddresses accept *:80

for env in $(printenv | grep '^TOR_'); do
The for loop uses space as a delimiter unless IFS is set to '\n'
Another problem here is that arguments other than [0-9]+|false|true are encapsulated in quotes which will not work for those settings.
In fact, there is not a single torrc setting that requires quotes. And even if necessary, the quotes could be added inside the environment var instead of forcing them on all non boolean/decimal values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant