Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will allow multiple arguments and spaces for custom settings.
some examples of settings requiring multiple arguments:
for env in $(printenv | grep '^TOR_'); do
The for loop uses space as a delimiter unless IFS is set to '\n'
Another problem here is that arguments other than [0-9]+|false|true are encapsulated in quotes which will not work for those settings.
In fact, there is not a single torrc setting that requires quotes. And even if necessary, the quotes could be added inside the environment var instead of forcing them on all non boolean/decimal values.