Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align field and column names with DraCor wording #180

Merged
merged 7 commits into from
Sep 22, 2024
Merged

Align field and column names with DraCor wording #180

merged 7 commits into from
Sep 22, 2024

Conversation

cmil
Copy link
Member

@cmil cmil commented Sep 20, 2024

resolve #173

@cmil cmil requested a review from lehkost September 20, 2024 00:38
@cmil cmil self-assigned this Sep 20, 2024
@cmil cmil added this to the 2.0 milestone Sep 20, 2024
@cmil
Copy link
Member Author

cmil commented Sep 20, 2024

I added this to milestone 2.0 because the renamed fields are a breaking change that requires a major version bump.

@cmil cmil requested a review from dilancakir September 20, 2024 06:46
Copy link
Member

@lehkost lehkost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this commit (e882096), printed: 1735-05-09 should be corrected to premiered: 1735-05-09

@cmil
Copy link
Member Author

cmil commented Sep 21, 2024

in this commit (e882096), printed: 1735-05-09 should be corrected to premiered: 1735-05-09

This is fixed with 284b89e

@cmil cmil requested a review from lehkost September 21, 2024 12:55
@cmil cmil merged commit ebb82d7 into main Sep 22, 2024
1 check passed
@cmil cmil deleted the 173-naming branch September 22, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align heads of column with mainstream DraCor wording
2 participants