-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/better gpu #286
Feature/better gpu #286
Conversation
Thank you for your extensive contribution. As this is such a large pull request, I would feel better if there was documentation for the new options, specifically for the apple GPU powermetrics option. I find it unlikely that most people will look in the code to see that they must add the command into their sudoers file.
Some Linux distributions may come with them preinstalled. |
im definitely adding all the options to the documentation im currently working on. |
Please do.
I am good with that. |
@@ -45,7 +57,7 @@ main() | |||
{ | |||
# storing the refresh rate in the variable RATE, default is 5 | |||
RATE=$(get_tmux_option "@dracula-refresh-rate" 5) | |||
gpu_label=$(get_tmux_option "@dracula-gpu-usage-label" "GPU") | |||
gpu_label=$(get_tmux_option "@dracula-gpu-power-label" "GPU") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break any existing configs. What is your rational for changing this?
} | ||
|
||
main() | ||
{ | ||
# storing the refresh rate in the variable RATE, default is 5 | ||
RATE=$(get_tmux_option "@dracula-refresh-rate" 5) | ||
gpu_label=$(get_tmux_option "@dracula-gpu-usage-label" "VRAM") | ||
gpu_label=$(get_tmux_option "@dracula-gpu-vram-label" "VRAM") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe VRAM should be its own config option and usage stay as it is.
currently we have three different widgets using the @dracula-gpu-usage-label option: usage, power, and vram. that doesnt make a lot of sense to me, especially since for vram it defaults to "VRAM" and power and usage default to "GPU". this differentiation of labels is lost as soon as the option is set. |
nvidia-smi detection is now used as fallback option. |
Thank you so much! I appreciate all the work you have done recently. |
and theres more work to come! |
Well everything you've submitted so far has been great! Keep doing what you're doing. |
current solution sadly requires sudo privileges. if i can find something better, i will make another pull-request
if nvidia-smi is not installed, it doesnt matter whether an NVIDIA gpu is installed, since we couldnt read the data anyways.
if it is installed, theres most probably also a gpu, because why would you install nvidia drivers otherwise?
by default its set to false, and doesnt do anything, but you can set it to "NVIDIA", making it as if NIVDIA was detected.
hopefully this will not need to be used for nvidia anymore with the switch to
type -a nvidia-smi
for detection.since i neither own an intel, nor amd gpu, i cannot test these changes for the respective brands. however im planning on teaming up soon to tackle that too.
roadmap: