Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(fs-lib): create /etc/fstab.empty runtime instead of buildtime #2386

Closed
wants to merge 1 commit into from
Closed

perf(fs-lib): create /etc/fstab.empty runtime instead of buildtime #2386

wants to merge 1 commit into from

Conversation

Henrik66
Copy link
Contributor

@Henrik66 Henrik66 commented Jun 11, 2023 •
edited
Loading

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #2371

@github-actions github-actions bot added fs-lib Issues related to the fs-lib module modules Issue tracker for all modules labels Jun 11, 2023
LaszloGombos
LaszloGombos approved these changes Jun 11, 2023
View reviewed changes
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It make sense to me to only create this empty file when it is actually needed.

Due to ramfs' design, at least one page will be allocated for one file however small the file is. On machine with large page size, this will become worse and waste too many memory.

@stale
Copy link

stale bot commented Jul 14, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Jul 14, 2023
@LaszloGombos LaszloGombos removed the stale communication is stuck label Jul 15, 2023
@LaszloGombos LaszloGombos added this to the dracut-060 milestone Jul 15, 2023
@LaszloGombos LaszloGombos mentioned this pull request Jul 20, 2023
Closed
@Henrik66 Henrik66 changed the title fix(fs-lib): create /etc/fstab.empty runtime instead of buildtime perf(fs-lib): create /etc/fstab.empty runtime instead of buildtime Jul 31, 2023
@LaszloGombos LaszloGombos modified the milestones: dracut-060, dracut-061 Oct 30, 2023
@aafeijoo-suse aafeijoo-suse removed this from the dracut-061 milestone Nov 18, 2023
@Henrik66 Henrik66 closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloGombos LaszloGombos LaszloGombos approved these changes

@haraldh haraldh Awaiting requested review from haraldh haraldh is a code owner

@johannbg johannbg Awaiting requested review from johannbg johannbg is a code owner

Assignees
No one assigned
Labels
fs-lib Issues related to the fs-lib module modules Issue tracker for all modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/etc/fstab.empty is created and not used
3 participants
@Henrik66 @LaszloGombos @aafeijoo-suse