-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improve maintenance of test containers #2423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Henrik66 .
Can you please also add pcsclite
package ?
Can you see if you can find a way not to install mkinitcpio
(the default initramfs
provider on arch) ? There is a possibly solution used in the Debian
container to avoid having initramfs-tools
installed.
I found out that assume-installed option can do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
3447d5d
to
edee523
Compare
782f746
to
bc8dd71
Compare
ebbe839
to
7164fb0
Compare
I think this helps reason about the differences of test containers, which should help reason about about test results. Let's use this opportunity to make a few more changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Hopefully this helps with maintenance - and at least now we have a list of common packages installed in the containers.
Install more packages to enable more testing on Arch.
The test code is harder to read and harder to copy-paste after this change. The list would be easier to maintain if the entries would be grouped by topic. Example question: Why is btrfs-progs not installed on openSUSE? There are many packages that just have different names. Having those in one place would help, but I have no idea how to codify that in a readable way.
|
This is subjective and I hope to avoid copy-paste.
This is a question I also had, but please recognize that this question probably would not even be on the table if we continue just copy-paste. This is one value of somehow harmonizing the containers.
Not that many, but some for sure.
I hope @aafeijoo-suse would also chime in here on what is his preference. In reality sometimes we need to investigate why a new dracut module or a new test-case fails only on one distribution. Having packages in one place would help.
I think @Henrik66 could work on making this syntax work if this is what it takes to reach a consensus. Some documentation also references package names - https://github.com/dracutdevs/dracut/blob/master/docs/README.generic . We should either remove these or replace them with some syntax that considers several distributions. |
Is this list referring to projects or package names? Also "Generic initramfs'es are huge (usually over 10 megs in size uncompressed)" is a little outdated. The generic initramfs is more around 100 MB and uncompressed in hundreds of megabytes. |
LGTM, although I've not verified the package lists. |
1f8ad12
to
2158862
Compare
Consolidate list of package generation into test-packages.sh tool. Add jq to all test containers. Remove g++, less and quilt from Debian test container. Add iscsiuio to dpkg based distributions.
2158862
to
1e35bd6
Compare
Install AUR helper (paru) into Arch test container and improve maintenance of test containers.
Pulls in #2427 as one of the commits in this PR.
Checklist
Fixes #2422 #2433