-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rngd): install system service file #2442
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The service shipped with rng-tools
is not ordered Before=systemd-udevd.service
and has a install section with WantedBy=multi-user.target
. Are you sure this change works?
CC: @rmetrich
Thanks for checking, let me test various systems. |
FTR this does not work atm. as |
516ee4f
to
a59c401
Compare
Is that RH specific? https://github.com/nhorman/rng-tools/blob/master/rngd.service |
dc7ecb4
to
4be439e
Compare
Unfortunately, yes, it seems we ship it https://src.fedoraproject.org/rpms/rng-tools/blob/rawhide/f/rngd.service | https://gitlab.com/redhat/centos-stream/rpms/rng-tools/-/blob/c9s/rngd.service |
4be439e
to
b060111
Compare
(Sorry about all of those pushes; I somehow thought I'd resolve it without testing first.) |
Added to commit message:
|
b060111
to
c47a44c
Compare
as there's no reason to keep a copy; there shouldn't be any modifications. In case there are args stored in a separate file (Fedora and alike), it needs to be supplied too, but without the option to change the user.
c47a44c
to
9f2b259
Compare
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
This is still pending merge. |
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
as there's no reason to keep a copy; there shouldn't be any modifications.
Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=2181541
Changes
Install system
rngd.service
file instead of a custom (bundled) one.Checklist