chore: remove unnecessary shellcheck disable for SC2154 #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
test
aafeijoo-suse
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Remove unnecessary shellcheck comments for SC2154 . The current version of shellcheck is smart enough to not require these opt-out comments.
Nah, it's not so clever, the thing is, it's explicitly disabled in .shellcheckrc. Try commenting out the following line before running shellcheck :)
Lines 9 to 11 in 1664563
Anyway, this change is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary shellcheck comments for SC2154 . The current version of shellcheck is smart enough to not require these opt-out comments.
This is a rebase from a PR closed earlier by the stale bot - #2235