Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install.d) Support ukify for kernel-install #2479

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahilarious
Copy link

@rahilarious rahilarious commented Aug 12, 2023

This patch allows users to generate UKI with systemd & use dracut for initramfs.

How it works

Recently (commit) ukify gained ability to add all initrd's placed in $KERNEL_INSTALL_STAGING_AREA to UKI file.
With this patch initrd will be placed in $KERNEL_INSTALL_STAGING_AREA for ukify users, allowing seamless automation with kernel-install.

Checklist

  • I have tested it locally with latest git versions of kernel-install (systemd) & dracut

Fixes

Need for hacks & hooks to let dracut & ukify get along well

@rahilarious rahilarious changed the title Support ukify for kernel-install feat(install.d) Support ukify for kernel-install Aug 12, 2023
@LaszloGombos
Copy link
Collaborator

LaszloGombos commented Aug 13, 2023

Need for hacks & hooks to let dracut-ukify get along well

Be careful for justifying this work with dracut-ukify. dracut-ukify seem to exists only as an AUR package for arch only. Generally distro specific changes will expect a bit more scrutiny - see https://github.com/dracutdevs/dracut/wiki/Dracut-development#reviews .

@rahilarious
Copy link
Author

dracut-ukify seem to exists only as an AUR package for arch only.

Well, I just used "dracut-ukify" as to indicate some kind of bridge/bond between two programs. Being a Gentoo user, I wasn't even aware that such thing exists in AUR.

Generally distro specific changes will expect a bit more scrutiny

Indeed, this is true, if this was about AUR package.(but it's not)

This will work on any distro with systemd-boot (yes even on gentoo with openrc) with latest git version (or >=systemd 254.2)

Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't agree with what this PR wants to add, so it's a no from me.

@rahilarious
Copy link
Author

Sorry, I don't agree with what this PR wants to add, so it's a no from me.

Seems like anti-ukifyism going on here. Some grudge against ukify/systemd? Anything related to it gets denied.

@aafeijoo-suse
Copy link
Member

Sorry, I don't agree with what this PR wants to add, so it's a no from me.

Seems like anti-ukifyism going on here. Some grudge against ukify/systemd? Anything related to it gets denied.

It's one thing to support kernel-install parameters within the kernel-install scripts shipped with dracut (#2495), and quite another to support other random uki generators and what they want to do.

You can interpret it as you wish.

@rahilarious
Copy link
Author

rahilarious commented Aug 24, 2023

quite another to support other random uki generators and what they want to do.

Sir, this is no random generator. Ukify is built into systemd.

It's one thing to support kernel-install

This patch IS about kernel-install script. So dracut will generate & copy initramfs to proper directory where it can be picked up by other plugins (install.d scripts)

@stale
Copy link

stale bot commented Oct 15, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale communication is stuck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants