Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dracut.sh): remove microcode check based on CONFIG_MICROCODE_[AMD|INTEL] #2481

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

aafeijoo-suse
Copy link
Member

CONFIG_MICROCODE_AMD and CONFIG_MICROCODE_INTEL are hidden since https://lore.kernel.org/all/[email protected]/, therefore this check is wrong and early microcode is always disabled.

Already merged into the tip tree, PR created as draft meanwhile it doesn't make it to the master branch.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

…|INTEL]

`CONFIG_MICROCODE_AMD` and `CONFIG_MICROCODE_INTEL` are hidden since
https://lore.kernel.org/all/[email protected]/, therefore
this check is wrong and early microcode is always disabled.
@lnykryn
Copy link
Member

lnykryn commented Aug 14, 2023

Do we need to wait to merge this? CONFIG_MICROCODE is set in the older kernels, so there should be no issue.
Well, there is a scenario where someone on intel compiles the kernel with CONFIG_MICROCODE_AMD=y and CONFIG_MICROCODE_INTEL=n, but ... meh.

@aafeijoo-suse
Copy link
Member Author

Do we need to wait to merge this? CONFIG_MICROCODE is set in the older kernels, so there should be no issue. Well, there is a scenario where someone on intel compiles the kernel with CONFIG_MICROCODE_AMD=y and CONFIG_MICROCODE_INTEL=n, but ... meh.

Ok, I agree.

@aafeijoo-suse aafeijoo-suse marked this pull request as ready for review August 14, 2023 12:44
@aafeijoo-suse
Copy link
Member Author

FTR, already merged into master (torvalds/linux@42a7f6e), this patch will be required for 6.6-rc1.

Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aafeijoo-suse aafeijoo-suse merged commit 6c80408 into dracutdevs:master Aug 30, 2023
86 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants