Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove unused packages from Debian container #2491

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bdrung
Copy link
Contributor

@bdrung bdrung commented Aug 19, 2023

Changes

Improve the Debian container:

  • The dash package is a required that must be present on all Debian systems.
  • The debhelper and quilt packages are only needed for packaging dracut.
  • To make the list of required packages more architecture independent, replace qemu-system-x86 by qemu-kvm in the Debian Docker image.
  • The Debian image uses initramfs-tools for generating the initramfs. Having initramfs-tools installed should not have any effect on running the test suite.

I tested locally that the changed container still successfully runs the tests that the integration test runs.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

The dash package is a required that must be present on all Debian
systems.

Signed-off-by: Benjamin Drung <[email protected]>
The debhelper and quilt packages are only needed for packaging dracut.

Signed-off-by: Benjamin Drung <[email protected]>
To make the list of required packages more architecture independent,
replace `qemu-system-x86` by `qemu-kvm` in the Debian Docker image.

Signed-off-by: Benjamin Drung <[email protected]>
The Debian image uses initramfs-tools for generating the initramfs.
Having initramfs-tools installed should not have any effect on running
the test suite.

Signed-off-by: Benjamin Drung <[email protected]>
@github-actions github-actions bot added the test Issues related to testing label Aug 19, 2023
@LaszloGombos
Copy link
Collaborator

The dash package is a required that must be present on all Debian systems.

It is correct that it is not required, but at the same time there is no obvious need for removing it.
One of my goals with test containers has been to align them between distributions when that is a reasonable to do so.
Listing dash explicitly is not needed currently for Debian based distributions but it is needed for some other distributions (such as Fedora or Arch), so I prefer to keep it fro Debian based distributions as well.

The debhelper and quilt packages are only needed for packaging dracut.

It is correct that it is not required, but at the same time there is no obvious need for removing it.
Recently it has been decided that packaging for distributions no longer maintained upstream, however packaging dependencies are still maintained in the distribution containers (e.g. rpm-build for Fedora or OpenSUSE).
This is intentional as I think we should make it easy to consume these test containers downstream as well, where packaging might actually happen inside the test container.
We should either remove all packaging related packages from all test containers or we should keep all of them. For this however we need to understand how packaging is done for Fedora and OpenSUSE as well.

To make the list of required packages more architecture independent, replace qemu-system-x86 by qemu-kvm in the Debian Docker image.

This is a very useful change. Yes please.

The Debian image uses initramfs-tools for generating the initramfs. Having initramfs-tools installed should not have any effect on running the test suite.

Would you had installed initramfs-tools explicitly if it would not be pulled in by an open bug ?
It should not be a goal upstream to make sure that dracut does not conflict with other initramfs generators.
We also do not install mkinitcpio on Arch just to make sure that dracut does not conflict with mkinitcpio.
BTW, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994492 is now fixed. The fix will not be available in debian:stable for a while but if this is important for the Ubuntu container then perhaps you can make this happen in the ubuntu:latest container.

@stale
Copy link

stale bot commented Oct 15, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale communication is stuck test Issues related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants