Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(numlock): add module to turn Num Lock on #2548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

innovara
Copy link
Contributor

@innovara innovara commented Nov 3, 2023

When you have to unlock an encrypted volume during bootup, it's generally, and arguably, more convenient to have Num Lock on by default to type your password. This is even more convenient when using hardware tokens, being smart cards or usb keys, as they generally use numeric PINs to unlock the slot holding the key.

The idea of how to do it comes from here: https://wiki.archlinux.org/title/Activating_numlock_on_bootup

Changes

This module adds setleds and a shell script to turn Num Lock on.

The module priority (90), the hook (initqueue/settled), and its priority (90) are purely my attempt at putting it where I think it can go. I chose the later hook in time for the unlocking of the encrypted volume, based on trial and error testing. I reckon the devs here can recommend changes in this regard.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@github-actions github-actions bot added the modules Issue tracker for all modules label Nov 3, 2023
@github-actions github-actions bot removed the modules Issue tracker for all modules label Nov 3, 2023
@github-actions github-actions bot added the modules Issue tracker for all modules label Nov 3, 2023
@LaszloGombos LaszloGombos added the enhancement Issue adding new functionality label Nov 4, 2023
@innovara
Copy link
Contributor Author

May I ask what are the next steps on a PR of this kind? Is it going to be merged on a future release? Is there anything I can do to help the process? I'd love to see it on the next version of Fedora.

This module adds setleds and a shell script to turn Num Lock on.

Useful when you have to type a  password or a PIN to unlock a volume.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue adding new functionality modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants