Context menu cache #1000
Open
Context menu cache #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
force-pushed
the
context-menu-cache
branch
from
d52ffd7
to
c65f047
Compare
We only used a specific cache on the context menu to ensure changes to plugins would invalidate the nested cache item and update the menu. This failed us in a couple of ways because the menu contains multilpe items: - Plugins based on instance - Links to Send To items based on project - Access to the links based on user permissions This means the cache would become so user specific it defeats it's own purpose. Instead, we can simply move the wider "page content" cache down the tree and skip caching the context menu.
brianp
force-pushed
the
context-menu-cache
branch
from
c65f047
to
4abf9d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We only used a specific cache on the context menu to ensure changes to
plugins would invalidate the nested cache item and update the menu. This
failed us in a couple of ways because the menu contains multiple items:
This means the cache would become so user specific it defeats it's own
purpose. Instead, we can simply move the wider "page content" cache down
the tree and skip caching the context menu.
Check List