Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heroku 1 click #1055

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

Fix heroku 1 click #1055

wants to merge 28 commits into from

Conversation

aapomm
Copy link
Contributor

@aapomm aapomm commented Jul 29, 2022

Spec

Errors for 1 click deploy:

app[web.1]: fatal: not a git repository (or any parent up to mount point /)
app[web.1]: Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
app[web.1]: NOTE: nokogumbo: Using Nokogiri::HTML5 provided by Nokogiri. See https://github.com/sparklemotion/nokogiri/issues/2205 for more information.
app[web.1]: Could not find server "". 
app[web.1]: Run `bin/rails server --help` for more options.

This seems to be caused by the Ruby 3 removing Webrick as a bundled gem. Previously, the deployed app uses Webrick by default when being deployed.

Proposed solution
The solution I went with is moving the Puma gem outside of the development group in the Gemfile allowing it to be installed and used on deploy.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Thanks for contributing to Dradis!

Copyright assignment

Collaboration is difficult with commercial closed source but we want
to keep as much of the OSS ethos as possible available to users
who want to fix it themselves.

In order to unambiguously own and sell Dradis Framework commercial
products, we must have the copyright associated with the entire
codebase. Any code you create which is merged must be owned by us.
That's not us trying to be a jerks, that's just the way it works.

Please review the CONTRIBUTING.md
file for the details.

You can delete this section, but the following sentence needs to
remain in the PR's description:

I assign all rights, including copyright, to any future Dradis
work by myself to Security Roots.

Check List

  • Added a CHANGELOG entry

@@ -10,7 +10,7 @@ spec:
value: enabled
scope: RUN_TIME
git:
branch: develop
branch: fix-heroku-1-click
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reverted to develop once merged/before merging.

config/cable.yml Outdated Show resolved Hide resolved
config/initializers/_preprovision_database.rb Outdated Show resolved Hide resolved
.do/deploy.template.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants