QA: State change activity #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapomm
reviewed
Mar 30, 2023
aapomm
reviewed
Mar 30, 2023
etdsoft
reviewed
Mar 31, 2023
| @@ -30,4 +30,8 @@ def track_recovered(trackable, user: current_user, project: current_project) | |||
| def track_updated(trackable, user: current_user, project: current_project) | |||
| track_activity(trackable, :update, user, project) | |||
| end | |||
|
|
|||
| def track_updated_state(trackable, user: current_user, project: current_project) | |||
There was a problem hiding this comment.
Don't love the name here, and looking at the presenter further down, what'd be the point of splitting the methods, and the action if we're not going to differentiate the view?
It seems to me that what we care about it's not the updating on an attribute, but the change in the QA state. Naming convention around QA state, and displaying a related message would be more useful
There was a problem hiding this comment.
Updated the name to track_state_change.
We are differentiating the view here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Track state changes and render them in the activity feed
Check List
- [ ] Added a CHANGELOG entry