Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attachment_spec #1159

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix attachment_spec #1159

merged 2 commits into from
Jul 14, 2023

Conversation

aapomm
Copy link
Contributor

@aapomm aapomm commented Jun 8, 2023

Summary

The current attachment_spec checks for the last attachment as it assumes that the last attachment will be the copied one. This change ensures that the copied attachment exists in the node and not rely on the last call to fetch the copied attachment.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Thanks for contributing to Dradis!

Copyright assignment

Collaboration is difficult with commercial closed source but we want
to keep as much of the OSS ethos as possible available to users
who want to fix it themselves.

In order to unambiguously own and sell Dradis Framework commercial
products, we must have the copyright associated with the entire
codebase. Any code you create which is merged must be owned by us.
That's not us trying to be a jerks, that's just the way it works.

Please review the CONTRIBUTING.md
file for the details.

You can delete this section, but the following sentence needs to
remain in the PR's description:

I assign all rights, including copyright, to any future Dradis
work by myself to Security Roots.

Check List

  • Added a CHANGELOG entry

@aapomm aapomm merged commit 1f58686 into develop Jul 14, 2023
3 checks passed
@aapomm aapomm deleted the fix-attachment-spec branch July 14, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant