Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid/async #1264

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Liquid/async #1264

merged 9 commits into from
Jun 6, 2024

Conversation

aapomm
Copy link
Contributor

@aapomm aapomm commented Jun 4, 2024

Summary

Currently, Liquid is evaluated inline when loading records, this slows down #show view load times.

Proposed solution

  • Asynchronously parse the content in #show
    • Pre-load the view with a lightweight markup (no liquid)
    • Add a JS fetch call for the show views and pass the content and project_id to the #preview endpoint. Replace the content in the show view with the response
  • Update the relevant specs
    • Remove all Liquid parsing inline checks in the relevant views
    • Test the #preview endpoint

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Thanks for contributing to Dradis!

Copyright assignment

Collaboration is difficult with commercial closed source but we want
to keep as much of the OSS ethos as possible available to users
who want to fix it themselves.

In order to unambiguously own and sell Dradis Framework commercial
products, we must have the copyright associated with the entire
codebase. Any code you create which is merged must be owned by us.
That's not us trying to be a jerks, that's just the way it works.

Please review the CONTRIBUTING.md
file for the details.

You can delete this section, but the following sentence needs to
remain in the PR's description:

I assign all rights, including copyright, to any future Dradis
work by myself to Security Roots.

Check List

  • Added a CHANGELOG entry

@aapomm aapomm changed the base branch from develop to liquid/all-project-drops June 5, 2024 11:57
@aapomm aapomm merged commit 0637a0f into liquid/all-project-drops Jun 6, 2024
3 checks passed
@aapomm aapomm deleted the liquid/async branch June 6, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants