update return_to before redirect to login #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapomm
reviewed
May 25, 2020
etdsoft
reviewed
Feb 1, 2022
aapomm
reviewed
Sep 16, 2022
spec/features/sessions_spec.rb
Outdated
| end | ||
|
|
||
| it 'redirects to previous page' do | ||
| Timecop.freeze(Time.now + 1.hour) do |
There was a problem hiding this comment.
Is there an alternative to using Timecop.freeze? Introducing more #freeze calls might cause issues in CI.
aapomm
reviewed
Sep 16, 2022
sean-yeoh
reviewed
Sep 19, 2022
| @@ -73,6 +73,8 @@ | |||
| # arbitrary gems may also be filtered via: | |||
| # config.filter_gems_from_backtrace("gem name") | |||
|
|
|||
| config.include ActiveSupport::Testing::TimeHelpers | |||
There was a problem hiding this comment.
To use https://api.rubyonrails.org/v5.2.4/classes/ActiveSupport/Testing/TimeHelpers.html instead of Timecop helpers: #700 (comment)
sean-yeoh
reviewed
Sep 19, 2022
| def return_to | ||
| if request.get? | ||
| warden_options[:attempted_path] | ||
| elsif request.post? |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spec
Currently, when a user is on any view and the session times out, the user is redirected back to the login view. Once logged back in the user goes to projects#show in ce or projects#index in pro.
Besides that, when they are using the editor while timed out, the preview on the right does not reflect their changes. (because they have been logged out). This isn't good UX and would confuse users.
Proposed solution
Return the user back to the page they were on when the session timed out.
While the user is on the editor while timed out, show an alert message to inform users to login again
Check List