Small onboarding tweaks to Welcome template #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattBudz
reviewed
Nov 17, 2021
| <% end %> | ||
| <% unless defined?(Dradis::Pro) && defined?(Dradis::Pro::Plugins::Remediationtracker) %> | ||
| <% if sync_plugins.any? %> | ||
| <div class="divider"></div> | ||
| <% end %> | ||
| <a href="javascript:void(0)" class="js-try-pro dropdown-item" data-term="remediation" data-url="https://dradisframework.com/pro/add-ons/remediation.html"><i class="fa fa-tasks fa-fw"></i> Built-in Remediation Tracker</a> | ||
| <a href="javascript:void(0)" class="js-try-pro dropdown-item" data-term="remediation" data-url="https://dradisframework.com/tools/remediation.html"><i class="fa fa-check-square-o fa-fw"></i> Built-in Remediation Tracker</a> |
There was a problem hiding this comment.
We specifically use pro/pages|addons for these modals because we are styling the pages in mind that they are likely viewed in a modal (hiding the website navbar & footer, and some other small adjustments).
I think a better approach would be to keep the pro/pages link here and update the pro/pages/remdiation.html page on the website
|
Needs a |
aapomm
reviewed
Nov 22, 2021
| <% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Vsts) %> | ||
| <a href="javascript:void(0)" class="js-try-pro dropdown-item" data-term="devops" data-url="https://dradisframework.com/pro/add-ons/azure-devops.html"><i class="fa fa-bolt fa-fw"></i> Ticketing: Azure DevOps</a> | ||
| <% end %> | ||
| <% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Vsts) %> |
There was a problem hiding this comment.
Suggested change
| <% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Vsts) %> | |
| <% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Jira) %> |
aapomm
reviewed
Nov 22, 2021
| <% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Vsts) %> | ||
| <a href="javascript:void(0)" class="js-try-pro dropdown-item" data-term="jira" data-url="https://dradisframework.com/pro/add-ons/jira.html"><i class="fa fa-bolt fa-fw"></i> Ticketing: JIRA</a> | ||
| <% end %> | ||
| <% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Vsts) %> |
There was a problem hiding this comment.
Suggested change
| <% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Vsts) %> | |
| <% unless defined?(Dradis::Pro) && defined?(Dradis::Plugins::Servicenow) %> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few small changes to make the Welcome project a bit more colorful (more users other than
adama@).Check List