Deal properly with dashed lists in source files #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dormi
reviewed
Oct 31, 2018
| def format_bullet_point_lists(input) | ||
| input.split("\n").map do |paragraph| | ||
| if paragraph =~ /^ - (.*)$/m | ||
| '* ' + $1.gsub(/ /, '').gsub(/\n/, ' ') | ||
| elsif paragraph =~ /^- (.*)$/m |
There was a problem hiding this comment.
We could use a single regex for both cases 🤔, checking for an optional white space
There was a problem hiding this comment.
May be with (^ *- (.*)$/m (http://rubular.com/r/iwSdcsGiPh)
Or we want to check only for exactly 0 or 2 whitespace cases?
There was a problem hiding this comment.
That's a much more elegant solution! Also, I bookmarked rubular to use in the future as I am not great at regex. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Nessus files contain a multitude of dashed lists that weren't being properly parsed into bullet lists with the
*syntax. This PR resolves this.