Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal properly with dashed lists in source files #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rachkor
Copy link
Member

@rachkor rachkor commented Oct 22, 2018

Some Nessus files contain a multitude of dashed lists that weren't being properly parsed into bullet lists with the * syntax. This PR resolves this.

def format_bullet_point_lists(input)
input.split("\n").map do |paragraph|
if paragraph =~ /^ - (.*)$/m
'* ' + $1.gsub(/ /, '').gsub(/\n/, ' ')
elsif paragraph =~ /^- (.*)$/m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use a single regex for both cases 🤔, checking for an optional white space

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be with (^ *- (.*)$/m (http://rubular.com/r/iwSdcsGiPh)
Or we want to check only for exactly 0 or 2 whitespace cases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a much more elegant solution! Also, I bookmarked rubular to use in the future as I am not great at regex. Thank you!

Base automatically changed from master to main January 29, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants