Cover ** and UnorderedList tags #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-yeoh
approved these changes
Jan 27, 2022
etdsoft
reviewed
Apr 22, 2022
lib/nexpose/vulnerability.rb
Outdated
| result.gsub!(/<OrderedList(.*?)>(.*?)<\/OrderedList>/m){|m| "#{ $2 }"} | ||
| result.gsub!(/<ListItem>|<\/ListItem>/, '') | ||
| result.gsub!(/<UnorderedList>|<\/UnorderedList>/, '') |
There was a problem hiding this comment.
Why is this needed? I'd expect L118 deals with this case.
added 2 commits
April 25, 2022 14:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parse
**correctly and clean upUnorderedListtags in the description field.Instances of
**can crash the entire Word export without a helpful error message to indicate the source of the problem. So, we need to remove them.This PR also includes a couple of updates to catch instances of
<UnorderedList>tags that weren't caught by the previous logic.