Add format_list method to handle Unordered and OrderedLists #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caitmich
reviewed
May 23, 2024
| module Dradis::Plugins::Nexpose | ||
| class ListFormatter | ||
| def format_list(source) | ||
| # Add <root> node in case the source is an invalid xml |
There was a problem hiding this comment.
Why do we still want to process invalid xml?
caitmich
reviewed
May 23, 2024
|
|
||
| def format_nexpose_list(xml, depth = 1) | ||
| xml.xpath('./UnorderedList | ./OrderedList').map do |list| | ||
| list_type = list.name == 'UnorderedList' ? '*' : '#' |
There was a problem hiding this comment.
Suggested change
| list_type = list.name == 'UnorderedList' ? '*' : '#' | |
| list_item_type = list.name == 'UnorderedList' ? '*' : '#' |
Or list_item_element / list_element ? Something a bit more descriptive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nexpose doesn't quite yet support / and it simply removes it from the output. We want to convert these to Textile's lists: * and #.
Proposed Solution
Parse the UnorderedList/OrderedList from the input and format them to use
*and#.Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Thanks for contributing to Dradis!
Copyright assignment
Collaboration is difficult with commercial closed source but we want
to keep as much of the OSS ethos as possible available to users
who want to fix it themselves.
In order to unambiguously own and sell Dradis Framework commercial
products, we must have the copyright associated with the entire
codebase. Any code you create which is merged must be owned by us.
That's not us trying to be a jerks, that's just the way it works.
Please review the CONTRIBUTING.md
file for the details.
You can delete this section, but the following sentence needs to
remain in the PR's description: