Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tracksViewChanges on marker clusters (47) #798

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Disable tracksViewChanges on marker clusters (47) #798

merged 1 commit into from
Oct 4, 2023

Conversation

YoussefHenna
Copy link
Collaborator

  • Disabling this prop can improve performance for custom markers (which is what a cluster is). It would only need to be enabled if the custom marker would dynamically change, which is not the case for clusters.

@YoussefHenna YoussefHenna added the legacy For a legacy branch using an older Expo version label Oct 4, 2023
@linear
Copy link

linear bot commented Oct 4, 2023

P-4143 Performance Issue with Map Component on Android.

This issue seems to due to custom marker images and a lot of markers being rendered on the map.

Initial Investigation:

  • Tried reducing the size of marker images, but it's still lagging on Android.

  • Verified by removing the custom marker images,  works well

This is impacting the final delivery of an expert app, so I am keeping it as a high priority.

Screen_Recording_20230929_181201_Dirt Near Me_2.mp4

Reproduction steps:

  • …

Expected behavior:

  • …

Observed behavior:

  • …

Environment:

  • staging
  • production

Browser:

  • Chrome
  • Safari
  • Firefox
  • Edge
  • Opera
  • Other

Device:

  • Apple
  • Android

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Published version: @draftbit/[email protected]

@YoussefHenna YoussefHenna changed the title Disable tracksViewChanges on marker clusters Disable tracksViewChanges on marker clusters (47) Oct 4, 2023
@YoussefHenna YoussefHenna merged commit f72fa2e into 47 Oct 4, 2023
@YoussefHenna YoussefHenna deleted the youssef/p-4143-performance-issue-with-map-component-on-android47 branch October 4, 2023 17:08
YoussefHenna added a commit that referenced this pull request Oct 5, 2023
@YoussefHenna
Revert "Disable tracksViewChanges on marker clusters (#798)"
9d9231b 
This reverts commit f72fa2e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@needs needs needs approved these changes

Assignees
No one assigned
Labels
legacy For a legacy branch using an older Expo version
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoussefHenna @needs