Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore textTransform uppercase label of TabView #799

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix: ignore textTransform uppercase label of TabView #799

merged 2 commits into from
Oct 4, 2023

Conversation

sieuhuflit
Copy link
Contributor

@sieuhuflit sieuhuflit commented Oct 4, 2023

Problem

File: react-native-tab-view/TabBarItem.tsx force label into uppercase

Screenshot 2023-10-04 at 17 30 42

Overview

  • Add textTransform to none to prevent uppercase of Tab view title

Demo

Screenshot 2023-10-04 at 17 23 32

Closes https://linear.app/draftbit/issue/P-4149/not-able-to-make-capitalize-tab-view-title

Copy link
Collaborator

@YoussefHenna YoussefHenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, just a minor comment

packages/core/src/components/TabView/TabView.tsx Outdated Show resolved Hide resolved
@YoussefHenna YoussefHenna merged commit 6e1b054 into draftbit:master Oct 4, 2023
1 check failed
YoussefHenna pushed a commit that referenced this pull request Oct 4, 2023
* fix: ignore textTransform uppercase of label

* chore: reverse the order of label style

---------

Co-authored-by: Sieu Thai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants