Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop to improve performance of MapView (47) #801

Conversation

YoussefHenna
Copy link
Collaborator

  • When the tracksViewChanges prop on markers is enabled, every marker on the screen keeps track of changes in the parent view. When there are many markers, this can create a sluggish and laggy map when trying to drag/pan (most noticeable on android).
  • This PR temporarily disables the prop when dragging then enables it after dragging stops
  • Disabling entirely creates another issue where markers and clusters are never updated, so this is best solution to prevent laggy panning while still allowing markers and clusters to be able to update.

@YoussefHenna YoussefHenna added the legacy For a legacy branch using an older Expo version label Oct 12, 2023
@linear
Copy link

linear bot commented Oct 12, 2023

P-4143 Performance Issue with Map Component on Android.

This issue seems to due to custom marker images and a lot of markers being rendered on the map.

Initial Investigation:

  • Tried reducing the size of marker images, but it's still lagging on Android.

  • Verified by removing the custom marker images,  works well

This is impacting the final delivery of an expert app, so I am keeping it as a high priority.

Screen_Recording_20230929_181201_Dirt Near Me_2.mp4

Reproduction steps:

Expected behavior:

Observed behavior:

Environment:

  • staging
  • production

Browser:

  • Chrome
  • Safari
  • Firefox
  • Edge
  • Opera
  • Other

Device:

  • Apple
  • Android

@sweep-ai
Copy link

sweep-ai bot commented Oct 12, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@github-actions
Copy link

Published version: @draftbit/[email protected]

@YoussefHenna YoussefHenna merged commit dc2646c into 47 Oct 12, 2023
1 check passed
@YoussefHenna YoussefHenna deleted the youssef/p-4143-performance-issue-with-map-component-on-android-new47 branch October 12, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy For a legacy branch using an older Expo version
Development

Successfully merging this pull request may close these issues.

1 participant