Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AvoidKeyboardView component #805

Merged

Conversation

YoussefHenna
Copy link
Collaborator

@YoussefHenna YoussefHenna commented Oct 22, 2023

  • Adds a simple wrapper component around react-native-avoid-softinput
  • Tested on a version of live preview with the package using a snack the uses the new component

@linear
Copy link

linear bot commented Oct 22, 2023

P-3946 Replace Keyboard Aware Scroll View

Discussion: https://draftbit.slack.com/archives/C040ES3HKV5/p1691608302620409

  • Test to determine which package is best as a replacement

  • https://mateusz1913.github.io/react-native-avoid-softinput/ seems like the best option. Will not work with Expo Go, will need some Live Preview changes.

  • In particular the AvoidSoftInputView can serve as a 1:1 replacement to KAV.

  • Test in Live Preview

  • Discuss implementation (UX, etc)

  • Create new component

  • QA new component

  • Release new component

@sweep-ai
Copy link

sweep-ai bot commented Oct 22, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@github-actions
Copy link

Published version: @draftbit/[email protected]

@YoussefHenna YoussefHenna changed the title WIP: Add AvoidKeyboardView component Add AvoidKeyboardView component Oct 22, 2023
@YoussefHenna YoussefHenna marked this pull request as ready for review October 22, 2023 11:34
@YoussefHenna YoussefHenna merged commit 27dc438 into master Oct 23, 2023
@YoussefHenna YoussefHenna deleted the youssef/p-3946-replace-keyboard-aware-scroll-view branch October 23, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant