Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some warnings #808

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Clean up some warnings #808

merged 2 commits into from
Oct 25, 2023

Conversation

YoussefHenna
Copy link
Collaborator

  • Remove traces of deprecated setNativeProps
  • Only use reanimated native driver when not on web
  • These should clean up some of the warnings seen in the builder

@linear
Copy link

linear bot commented Oct 25, 2023

P-4194 Sentry Logs in Builder Visible to Users

Sentry logs that are present within the builder are being displayed to our users. This has the potential to cause confusion or conflict for the users.

Additional Details:

@sweep-ai
Copy link

sweep-ai bot commented Oct 25, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@github-actions
Copy link

Published version: @draftbit/[email protected]

@YoussefHenna YoussefHenna merged commit 70a08d1 into master Oct 25, 2023
@YoussefHenna YoussefHenna deleted the youssef/p-4194-sentry-logs-in-builder-visible-to-users branch October 25, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@needs needs needs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoussefHenna @needs