Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Expo 49 #809

Merged
merged 19 commits into from
Oct 31, 2023
Merged

Upgrade to Expo 49 #809

merged 19 commits into from
Oct 31, 2023

Conversation

YoussefHenna
Copy link
Collaborator

@YoussefHenna YoussefHenna commented Oct 25, 2023 •
edited
Loading

  • Upgrades packages
  • Move away from expo-yarn-worksapces which is deprecated and used outdated packages
  • Use https://gorhom.github.io/react-native-bottom-sheet/ for the bottom sheet. Our old implementation relied on reanimated v1 APIs which were removed from reanimated v3.
    • All props are the same and supported in new package
    • Final output is pretty much the same, maybe even better. The new package gives us new possibilities that we could implement at some point like BottomSheetFlatList for example.
  • Changes here and there to get everything running
  • 48 version of jigsaw will be maintained on the 48 branch, this should be merged to master

@linear
Copy link

linear bot commented Oct 25, 2023

P-4007 Expo 49 version of Jigsaw

@sweep-ai
Copy link

sweep-ai bot commented Oct 25, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@YoussefHenna YoussefHenna marked this pull request as draft October 25, 2023 17:17
@github-actions
Copy link

Published version: @draftbit/[email protected]

@github-actions
Copy link

Published version: @draftbit/[email protected]

@YoussefHenna YoussefHenna marked this pull request as ready for review October 29, 2023 14:29
@github-actions
Copy link

Published version: @draftbit/[email protected]

1 similar comment
@github-actions
Copy link

Published version: @draftbit/[email protected]

needs
needs approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@needs needs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@YoussefHenna YoussefHenna merged commit b07029d into master Oct 31, 2023
1 check passed
@YoussefHenna YoussefHenna deleted the youssef/p-4007-expo-49-version-of-jigsaw branch October 31, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@needs needs needs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoussefHenna @needs