Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expo image #968

Merged
merged 15 commits into from
Dec 4, 2024
Merged

Support expo image #968

merged 15 commits into from
Dec 4, 2024

Conversation

sieu-db
Copy link
Collaborator

@sieu-db sieu-db commented Nov 18, 2024

Overview

  • Support expo-image
  • Provide the method convert from image to expoImage without any migrations
  • Support some additional props for expo-image (transition, blurhash ...etc...)
  • Add expo image example
  • Support remote SVG & local SVG
  • Support correctly for web also

Demo

Screen.Recording.2024-11-18.at.10.59.31.AM.mov

Important

Add support for expo-image with new features and examples, updating Image.tsx and adding ExpoImageExample.tsx.

  • Behavior:
    • Replace NativeImage with ExpoImage in Image.tsx to support expo-image features.
    • Add support for transition, blurhash, contentFit, contentPosition, cachePolicy, allowDownscaling, and recyclingKey in Image.tsx.
    • Add ExpoImageExample.tsx to demonstrate expo-image features, including remote/local images, aspect ratios, and SVGs.
  • Dependencies:
    • Add expo-image version 1.10.6 to package.json.
  • Misc:
    • Add ExpoImageExample to App.tsx routes.
    • Export ExpoImage in index.tsx of core and ui packages.

This description was created by Ellipsis for 1397b7a. It will automatically update as commits are pushed.

Copy link

linear bot commented Nov 18, 2024

@sieu-db sieu-db requested a review from YoussefHenna November 18, 2024 04:02
packages/core/src/components/Image.tsx Outdated Show resolved Hide resolved
packages/core/src/components/Image.tsx Outdated Show resolved Hide resolved
Copy link

Published version: @draftbit/[email protected]

Copy link

Published version: @draftbit/[email protected]

@sieu-db sieu-db marked this pull request as draft November 18, 2024 04:19
Copy link

Published version: @draftbit/[email protected]

Copy link

Published version: @draftbit/[email protected]

@YoussefHenna YoussefHenna mentioned this pull request Nov 28, 2024
Copy link

Published version: @draftbit/[email protected]

Copy link

Published version: @draftbit/[email protected]

@draftbitbuildservices draftbitbuildservices changed the base branch from master to 50 December 3, 2024 07:52
@draftbitbuildservices draftbitbuildservices marked this pull request as ready for review December 3, 2024 07:53
Copy link

github-actions bot commented Dec 3, 2024

Published version: @draftbit/[email protected]

Copy link

github-actions bot commented Dec 3, 2024

Published version: @draftbit/[email protected]

Copy link
Collaborator

@YoussefHenna YoussefHenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, but I think we need to address the double style thing before merging.

packages/core/src/components/ExpoImage.tsx Outdated Show resolved Hide resolved
packages/core/src/components/ExpoImage.tsx Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 3, 2024

Published version: @draftbit/[email protected]

Copy link

github-actions bot commented Dec 4, 2024

Published version: @draftbit/[email protected]

@sieu-db sieu-db merged commit 00b439b into 50 Dec 4, 2024
1 check passed
@sieu-db sieu-db deleted the sieu/p-3479-support-expo-image branch December 4, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants