-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix theme proxy generation performance issue #971
Merged
YoussefHenna
merged 15 commits into
master
from
youssef/p-5705-super-lag-after-recent-published-application
Nov 20, 2024
Merged
Fix theme proxy generation performance issue #971
YoussefHenna
merged 15 commits into
master
from
youssef/p-5705-super-lag-after-recent-published-application
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoussefHenna
changed the title
logging and prevent excessive theme changes
Fix performance issues
Nov 20, 2024
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
YoussefHenna
changed the title
Fix performance issues
Fix theme proxy generation performance issue
Nov 20, 2024
needs
approved these changes
Nov 20, 2024
YoussefHenna
deleted the
youssef/p-5705-super-lag-after-recent-published-application
branch
November 20, 2024 12:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zod
not being performant enough to use in the proxy generation logic (which is called everytime a theme value is used)zod
for the initial validation only (as it was intended to be used) and uses simpler util functions in the theme value proxy generation.Important
Improves theme proxy generation performance by replacing
zod
with utility functions for runtime checks, retainingzod
for initial validation.zod
with utility functionsisTextStyleObject
andasThemeValuesObject
increateThemeValuesProxy.ts
for runtime checks.zod
for initial validation invalidators.ts
.isTextStyleObject
andasThemeValuesObject
fromvalidators.ts
toutils.ts
.lodash.isobject
topackage.json
for object checks.This description was created by for a1ef4c1. It will automatically update as commits are pushed.