Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DELETE method #31

Open
dandv opened this issue Jul 16, 2018 · 4 comments · May be fixed by #167
Open

Support DELETE method #31

dandv opened this issue Jul 16, 2018 · 4 comments · May be fixed by #167
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dandv
Copy link
Collaborator

dandv commented Jul 16, 2018 •
edited
Loading

We only support .get() and .post() now, but there's also DELETE:
@dandv dandv added the good first issue Good for newcomers label Jul 16, 2018
@dandv dandv mentioned this issue Jan 20, 2019
Closed
@CannibalKush
Copy link

CannibalKush commented Feb 25, 2019 •
edited
Loading

Well shit, went and built 80% of my API with this library but can't use Delete.

Damn!

@dandv
Copy link
Collaborator Author

dandv commented Feb 25, 2019

This is how open source works. There has been insufficient demand + developer time to implement delete.

You're free to implement it (the source code is well-commented, and you can have a look at the PUT PR), or use another library.

@CannibalKush
Copy link

Yeah sorry i wrote that issue in frustration. i just might implement it actually.

@dylanirlbeck
Copy link
Contributor

I'm going to try and tackle this issue. @dandv If there's anything I should know about DELETE and the Twitter API, please let me know!

I'll try to have a PR out soon.

@dylanirlbeck dylanirlbeck mentioned this issue Jan 12, 2020
Merged
@dylanirlbeck dylanirlbeck added the enhancement New feature or request label Feb 20, 2020
@camergardi
Copy link

@dylanirlbeck Any update on this?

@LoSunny
Copy link

LoSunny commented Feb 18, 2021

It's been some days since this issue, anyone got any updates?

@dbredvick dbredvick linked a pull request May 12, 2021 that will close this issue
Open
@ciffelia ciffelia mentioned this issue Aug 12, 2021
Closed
@dylanirlbeck dylanirlbeck removed their assignment Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add delete support dbredvick/twitter-lite
5 participants
@dandv @camergardi @LoSunny @dylanirlbeck @CannibalKush