Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding put method with test #56

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

dylanirlbeck
Copy link
Contributor

@dylanirlbeck dylanirlbeck commented Jan 12, 2020

Fixes #39

As far as I can tell, there is only one PUT endpoint located here; thus, this is the only endpoint I am testing in twitter.test.js.

@peterpme I was a little unsure of why es-lint was adding a trailing comma to line 255 and 260 in test/twitter.test.js, but it seems like that's expected behavior for the es-lint config file at the project root. If these changes should not be included then please let me know and I'll remove them from the commit.

Once this PR gets merged I'll move on to #31 (DELETE). Thanks!

@dylanirlbeck dylanirlbeck requested a review from peterpme January 12, 2020 23:16
@dylanirlbeck dylanirlbeck merged commit ce85352 into draftbit:master Jan 17, 2020
@dylanirlbeck dylanirlbeck deleted the add-put-method branch January 17, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support PUT method
1 participant