-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Twitter Labs filter stream v1 support #127
base: master
Are you sure you want to change the base?
Conversation
4d12951
to
3857bc0
Compare
I need it as well, I hope it's going to be merged. |
3857bc0
to
ac73928
Compare
We'll merge this, thanks :) |
@peterpme I didn't make documentation changes on the README, would you like me to do that? |
Yes please, thank you!!! Sorry for the delay |
In detail: - added API calls for adding, deleting and getting filter stream rules - added stream API call - added appropriate types - attempted to stick with current code and exporting structure - updated README
ac73928
to
e19353c
Compare
@peterpme been busy, but just pushed the updated README :) |
Hey @btruhand wow this is amazing, thank you so much! are you ready for this to be merged in? |
@peterpme absolutely. From my end there is nothing else I'd like to do, merge whenever you are comfortable with it. I hope it can help pave the way for others to add more Twitter Labs functionalities Edit: Oh just to make sure, I didn't add to the github workflows pipeline to run the twitter labs related tests (since it uses a different command name). I think I'll leave that to you to decide on when to add it since you will have to opt in to the Twitter Labs functionality |
@peterpme hey peter, just noticed recently that Twitter announced official v2 API for filter stream: https://developer.twitter.com/en/docs/labs/filtered-stream/overview. It's a bit different but would make this PR ineffective I'll try to find time to modify the PR in the upcoming month or so. Tell me if you want me to remove or retain the |
I found the new Twitter Labs filter stream (https://developer.twitter.com/en/docs/labs/filtered-stream/overview) to be more fitting for my use case so I decided to add it as several new function API calls
In detail:
When I tried to run the tests there are some tests that failed, but doesn't seem to be related to the additions/changes I made:
I didn't make tests for the filter stream API call itself since I used the current
Stream
class, but tell me if you want me to still add tests for them (or try to at least test for the query parameters properly being created etc.)