Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report which undeclared key scripts attempted to access #3212

Open
chakaz opened this issue Jun 25, 2024 · 0 comments · May be fixed by #3245
Open

Report which undeclared key scripts attempted to access #3212

chakaz opened this issue Jun 25, 2024 · 0 comments · May be fixed by #3245
Assignees
@chakaz
Labels
Next Up task that is ready to be worked on and should be added to working queue

Comments

@chakaz
Copy link
Collaborator

chakaz commented Jun 25, 2024 •
edited
Loading

Today, when a Lua script tries to access an undeclared key we just return an error such as:

Error running script (call to <hash>): @user_script:248: script tried accessing undeclared key

To make debugging easier, we should print which key was attempted to access. This could help, for example, when the key is missing hashtags, etc

Note to future self: CheckKeysDeclared should likely return the key at hand if indeed it fails.
@chakaz chakaz self-assigned this Jun 25, 2024
@romange romange added the Next Up task that is ready to be worked on and should be added to working queue label Jun 25, 2024
@chakaz chakaz linked a pull request Jun 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakaz chakaz

Labels
Next Up task that is ready to be worked on and should be added to working queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(lua): Return which undeclared key was accessed dragonflydb/dragonfly
2 participants
@romange @chakaz