chore(lua): Return which undeclared key was accessed #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example:
```
127.0.0.1:6379> EVAL "return redis.call('SET', 'k', 'v')" 0
(error) ERR Error running script (call to 5c4d62f4e30c54fb15935b5892148e5ce7374077): @user_script:2: script tried accessing undeclared key, key: k
```
kostasrim
previously approved these changes
Jun 30, 2024
adiholden
reviewed
Jun 30, 2024
src/server/main_service.cc
Outdated
| @@ -967,7 +967,7 @@ optional<ErrorReply> Service::CheckKeysOwnership(const CommandId* cid, CmdArgLis | |||
| // Return OK if all keys are allowed to be accessed: either declared in EVAL or | |||
| // transaction is running in global or non-atomic mode. | |||
| OpStatus CheckKeysDeclared(const ConnectionState::ScriptInfo& eval_info, const CommandId* cid, | |||
There was a problem hiding this comment.
maybe this function can return ErrorReply? instead of status and out param in case of error
There was a problem hiding this comment.
This is a great idea! Done.
kostasrim
approved these changes
Jun 30, 2024
adiholden
approved these changes
Jul 1, 2024
romange
added a commit
that referenced
this pull request
Jul 2, 2024
* chore(lua): Return which undeclared key was accessed
Example:
```
127.0.0.1:6379> EVAL "return redis.call('SET', 'k', 'v')" 0
(error) ERR Error running script (call to 5c4d62f4e30c54fb15935b5892148e5ce7374077): @user_script:2: script tried accessing undeclared key, key: k
```
* fix
---------
Co-authored-by: Roman Gershman <[email protected]>
Signed-off-by: Roman Gershman <[email protected]>
adiholden
pushed a commit
that referenced
this pull request
Jul 2, 2024
* chore(lua): Return which undeclared key was accessed
Example:
```
127.0.0.1:6379> EVAL "return redis.call('SET', 'k', 'v')" 0
(error) ERR Error running script (call to 5c4d62f4e30c54fb15935b5892148e5ce7374077): @user_script:2: script tried accessing undeclared key, key: k
```
* fix
---------
Co-authored-by: Roman Gershman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Fixes #3212